Game map : timer not starting (seems frozen)

Submitted by Realia on Fri, 10/18/2024 - 11:16
Forums: 
Bugs in content types

Hello !

I am using Game Map (latest version, freshly downloaded from Oliver's website) on Wordpress 6.6.2 with the H5P plugin completely updated. I am using Chrome as my browser (Version 128.0.6613.138 (Build officiel) (x86_64)).

When I set a time limit to an activity or to the entire game, the timer doesn't start. Here is a screenshot with the error showing up in the console :

The timer was working well with the "official - non updated" version of Game Map ; it stopped working when I updated Game Map this morning with the demo content downloaded on Oliver's website. As a matter of fact, on Oliver's demo page (https://www.olivertacke.de/labs/2023/03/02/heres-game-map-my-25th-h5p-co...), the timer is also frozen.

So i am wondering : is the matter caused by my browser ? Is it on my end only ?

Thanks for any help provided !

Isabelle

Content types: 
wordpress
otacke's picture

otacke

Fri, 10/18/2024 - 21:26

It's a bug. Fixed in version 1.3.6 of GameMap.

Realia

Fri, 10/18/2024 - 22:33

Hi Oliver !

I was browsing your website a few minutes ago because I had set my mind on updating all the H5P content-types made by you that I am using. So there I was, browsing the Info Wall content (thumbs up for this handy listing : it is very helpful to know which contents to update), when I stumbled upon Game Map and noticed that the content-type had been updated... today ?! I was intrigued, jumped to the demo-content and noticed that the timer was smoothly running... unfrozen. I thought to myself : "No way ! It can't be fixed already !" Then I rushed to this very thread and found your reply : I couldn't believe it ! I am truly grateful for the fix and quite amazed by how quick you published it. When I posted my question this morning, I wasn't sure that it was a bug, as my Mac is getting old (born 2013 !... ) and is acting weird from time to time. Also I was surprised that no one had pointed out any issue with the timer (I searched the forum and found nothing). I have updated Game Map and the timer is now running perfectly.

By the way, I am a bit curious regarding the versioning of your H5P content-types : how does this work ? For instance, the previous version of Game Map was 1.3.5. How come you didn't name the version you patched today 1.4 ? What makes a content-type move from 1.3.5 to 1.3.6 instead of 1.4 ? (This is just out of curiosity.)

Anyway, thank you very much for fixing the broken timer :)

Cheers,

Isabelle

otacke's picture

otacke

Fri, 10/18/2024 - 23:56

Hi Isabelle!

There's a concept named semantic versioning which most developers follow, I think: https://semver.org/

I bumped the patch version, because the change merely fixed a bug.

Some changes will require you to bump the minor version instead, e.g. when you reference a new minor version of a subcontent type, if you add functions that other components could use, if you need to change the parameter structure, if you change the visual appearance (a lot), etc.

And, in theory, content types could also get a major update that would make it incompatible with older versions, then the major version would change. But that never occurred for H5P so far.

Realia

Mon, 10/21/2024 - 16:58

Hi Oliver,

Thank you for taking the time to explain this to me and for the link. I had never heared about semantic versioning before. The rules are very precise, it is almost artistic ;) To sum up :

  • 1.3.5 to 2.0 = major update + no more compatibility with older versions.
  • 1.3.5 to 1.4 = changes + retro-compatability OK
  • 1.3.5 to 1.3.6 = corrections (small changes like fixing a bug or typos)

I am glad to know this ! Thanks again :)

Isabelle

otacke's picture

otacke

Mon, 10/21/2024 - 17:26

Hi Isabelle!

You grasped that precisely!

Best,
Oliver