Video captions not showing in medium and small devices

Submitted by nstylianides on Thu, 11/12/2020 - 13:42
Forums: 
Bugs in content types

Hi there. 

Did anyone have the same experience with this?

1. When in small and medium devices the "CC" button only shown if twice clicked. 

2. menu with class "h5p-chooser h5p-captions" is not rendered. So even if we make the CC button appear, pressing it does not creates the captions selection menu. 

 

 

 

BV52's picture

BV52

Thu, 11/12/2020 - 18:17

Hi,

I think this is related to this bug report.

-BV

nstylianides

Thu, 11/12/2020 - 18:25

Hi there. Thank you for replying. Its not clear for me if its fixed. It seems that for the past year nobody was able to fix it.

Am i wrong?

BV52's picture

BV52

Fri, 11/13/2020 - 02:45

Hi nstylianides,

You are correct there is no resolution yet for this particular issue.

-BV

nstylianides

Fri, 11/13/2020 - 12:06

Maybe we can help. How can i start bug fixing?

BV52's picture

BV52

Fri, 11/13/2020 - 17:33

Hi nstylianides,

These documentation will give you an idea in regards to developing/bug fixing H5Ps. You can fork the code here.

-BV

nstylianides

Fri, 11/13/2020 - 19:33

Still not clear to me how to use it. 

i have downloaded the code from github. How to include a video and the subtitles so that i can test it, find the bug and solve it?

I can solve the issue for everyone. 

Thank you in advance. 

 

BV52's picture

BV52

Mon, 11/16/2020 - 17:25

Hi nstylianides,

First you need to setup your dev environment. Install the libraries there and debug from there. I'm afraid I cannot provide you more as my coding skills are novice at best.

-BV

nstylianides

Tue, 11/17/2020 - 17:31

Hi BV52, 

problem solved. How can i push the modifications and get it on the production solution?

 

 

BV52's picture

BV52

Tue, 11/17/2020 - 19:20

Hi nstylianides,

Thank you for your contribution. You can file a PR in Interactive Video's repo.

-BV

nstylianides

Mon, 11/30/2020 - 10:16

Hi BV, 

i am using Windows and believe me it has been really a challenge to create the PR. 

The code i have applied is only 3 lines in 3 files. Is there someone that already is a developer to send the code and he applies the modifications so that in the next release the problem is solved? 

 

 

 

 

BV52's picture

BV52

Tue, 12/01/2020 - 17:10

Hi nstylianides,

I'm no developer but I have tinkered enough in Guthub to be able to file the PR for you. If you can provide the code and files that were edited I'll gladly do this for you.

-BV

nstylianides

Tue, 12/01/2020 - 21:05

Hi BV, 

i created the Pull Request. Although because of my code formatting Github shows too many diffs. I have marked my modifications with the "NSTYLIANIDES" label. I hope is clear enough. 

 

BV52's picture

BV52

Wed, 12/02/2020 - 17:31

Hi nstylianides,

Thank you, we just need to wait for the H5P core team to test, merge the PR and release the update.

-BV

navneet.mca10

Tue, 05/25/2021 - 07:49

Hi NSTYLIANIDES

Can you please provide changes with files and comment, i have pull the git code and unable to find changes with label "NSTYLIANIDES"

Navneet

nstylianides

Wed, 08/25/2021 - 10:37

I apologize for the late reply. For some reason the email got into my SPAM folder. 

I have marked it with LEAFNET. Not NSTYLIANIDES. 

But i think it was obvious. Did you find any time to fix the code? 

Is not that convinient to hack it after creation. 

Thank you in advance and i again apologize.

 

rajeev_923

Tue, 08/24/2021 - 08:17

Hi nstylianides,

Can you please share the code? I have same issue.