Questionnaire apostrophe error/bug

Submitted by ajturner3 on Thu, 07/18/2019 - 18:58
Forums: 
Bugs in content types

We're having an issue where apostophes aren't rendering correctly (the html code ' is coming up instead) in the submit page of our questionnaire. It seems like they work elsewhere in the activity type which is weird. 

I've uploaded the .h5p to this post with an embed -- Any help would be appreciated!

 

H5P file: 
Binary Data exercice-autocorrectif-1-2-183.h5p
BV52's picture

BV52

Thu, 07/18/2019 - 20:30

Hi ajturner3,

Thank you for reporting this. I created a bug report and you can follow the progress here.

-BV52

ajturner3

Mon, 07/22/2019 - 19:49

HI BV52! 

Thanks for the note -- I appreciate your promptness. 

I also noticed a related issue where quotation marks also have a similar issue (are displayed as ")

otacke's picture

otacke

Tue, 07/23/2019 - 08:37

Hi ajturner3!

I have contributed the code that fixes those issues. You can track progress using the link that BV mentioned. Please note that the core team can't name a release date.

Best,

Oliver 

ajturner3

Tue, 07/23/2019 - 16:40

That's great news! thanks so much for your work! 

is there a way we could force update our questionnaire libraries to your fixed version in the meantime? (also is there a reason we woudln't want to do that?) 

otacke's picture

otacke

Tue, 07/23/2019 - 18:02

Hi ajturner3!

The pull request is linked to in the JIRA issue that you can use to track progress. So yes, you could patch your system right away, but you would probably not want to do that if the H5P core team can't confirm that my changes will become part of the official code. In that case, you'd have to patch each time an update for the content type is released.

Cheers,
Oliver

ajturner3

Wed, 07/24/2019 - 20:11

Thanks so much for the clarification and your help with this issue, Oliver!

Out of curiosity, is there anything I can do to help move this process along? The French instructor who plans to teach with this (and other H5P questions) is preparing for when his course starts in September, and he is very apprehensive that the issue won't be resolved before his courses start. 

Actually, any insight you can provide into the process by which pull requests are merged into the core code-base would be really helpful to report back to him in case the issue isn't resolved before then.  

otacke's picture

otacke

Wed, 07/24/2019 - 20:28

Hi ajturner3!

You should probably address the H5P core team, not me. They have a lot on their plates even without having to review pull requests by external contributors like myself.

Best,

Oliver 

ajturner3

Tue, 08/06/2019 - 19:02

Hi again BV52!

Just wanted to ask if there was any information about when these fixes will be applied to the open ended question libraries. 

Thanks much

BV52's picture

BV52

Tue, 08/06/2019 - 19:42

Hi ajturner3,

Sorry no updates yet but I will follow up with the core team.

-BV52