SVG?

Submitted by cperg on Thu, 02/26/2015 - 23:47
cperg's picture
Forums: 
General discussion

I have been using SVG for most of my responsive designs for the past 6 months. The Picture content type restricts the pictures to jpg, png and gif. It also states a specific size in pixels which does not work for responsive in any of the bit mapped image types. Should I create a second content type as "Responsive Picture" or is it better to work on the existing one and upload the changes to a branch in git?

 

falcon's picture

falcon

Fri, 02/27/2015 - 11:02

Hi!

  1. You'll need to change H5P core to allow svg. A patch or pull request would be much appreciated!
  2. H5PImage uses 100 % for both width and height? It has data about the pixel widht and height but doesn't add it to the html? In Coursepresentation for instance you'll see that the images gets bigger if the presentation canvas gets bigger, for instance if you enter fullscreen mode.

 

cperg's picture

cperg

Mon, 03/02/2015 - 16:55

I will get to the changes in the F5P core. As for the H5PImage pixel entries when left blank being defaulted to 100% height and 100% width. Perhaps there is a need to retain the original aspect ratio for the image in some instances. I will look at adding a check box that will only appear when both are empty with a more deatiled description in the interface for all of the sizing entries. This should clairfy the use of the image controls. Let me know about your thoughts on these changes.

falcon's picture

falcon

Tue, 03/03/2015 - 15:23

Currently H5P.Image works well in coursepresentation, Interactive Video and Drag and drop. The aspect ratio could be handled better there as well. In other content types where the image isn't inside a sized container created by the author it doesn't work that good.

The question is: Should H5P.Image support sizing or should the library using H5P.Image add styling or a container for sizing the image? I do think that H5P image should have more controls for sizing, and that Coursepresentation and other libraries that don't need these controls should hide them when they're not needed.

cperg's picture

cperg

Tue, 03/03/2015 - 00:39

There is a pull request for this one issue.

cperg's picture

cperg

Tue, 03/03/2015 - 00:47

I wil look at an issue we found while in the last. The creation of folders to hold images audio and video has rights issues - missing the group X and the other X values. I believe this would be in the speciic module for Drupal. I will look at that next.

falcon's picture

falcon

Tue, 03/03/2015 - 15:24

Ok, I gave some feedback on the pull request as well. Glad you're working on this!