Single quotes unescaped in the titles links (interactive book)
Submitted by Realia on Wed, 03/22/2023 - 20:06
Forums:
Hello !
I noticed today that the apostrophes / single quotes in the titles of the chapters summary show weird HTML characters. Not a big deal at all (there is a workaround) but, as I know that this issue impacts several other content-types, I thought that I should point it out as well :
Cheers,
Isabelle
Attachments:
Content types:
Realia
Thu, 03/23/2023 - 10:51
Permalink
Hi !While I am at it, I
Hi !
While I am at it, I noticed a missing title in the interactive book. In the language file, there is a field that we fill regarding the hamburger menu that can be expansed or not :
But contrary as the other icons, this label doesn't show up in the interactive book :
Oliver pointed out that titles raise accessibility issues ; I report this however because maybe there would be otherwise a lack of consistency in the UI ;)
Cheers,
Isabelle
otacke
Thu, 03/23/2023 - 22:32
Permalink
Hi!The translation value
Hi!
The translation value itself is used for the `aria-label` atteibute of the button element which is absolutely fine.
The `title` attribute should not be used anywhere for accessibility reasons, but it will eventually be replaced by a custom tooltip. So the problem rather is not a missing `title` but too man being set.
I assume that the H5P core team is trying to prevent to touch the same code twice, the first time for removing the `title` attributes and the second time to add the upcoming custom tooltip solution. I suppose they are planning todo that in one go, but that's merely speculation, of course.
Best,
Oliver
Realia
Tue, 04/04/2023 - 09:13
Permalink
Hi Oliver !Sorry I missed
Hi Oliver !
Sorry I missed your reply yesterday and thaks for it. Your speculations are probably correct : the H5P core team probably would rather "clean" titles and add the upcoming tooltip solution in one go for a better efficiency.
Best,
Isabelle